-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1397 #1398
Issue 1397 #1398
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 66.00% 66.23% +0.22%
==========================================
Files 194 191 -3
Lines 20528 20640 +112
Branches 4455 4528 +73
==========================================
+ Hits 13550 13670 +120
+ Misses 6978 6970 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but would like to see array arguments and cleanup as per that.
let queryParams = [code, ...packageIds, code, ...packageIds] | ||
|
||
// Since packageIds is now always an array, adjust the query and parameters accordingly | ||
const placeholders = packageIds.map(() => '?').join(', ') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do the standard:
IN (${dbApi.toInClause(packageIds)})
…g a Number to be passed as an alternative
Fixes #1397
This pull request retrieves the cluster/attribute pairs for all attributeAccessInterface attributes, including those of the list type.
Background: The ATTRIBUTE table designates CLUSTER_REF as null for global attributes.
To incorporate cluster/attribute pairs that are global attributes, the attributeAccessInterface list from zcl.json needs to be imported into an alternative table, PACKAGE_OPTION.
Given that PACKAGE_OPTION exclusively contains pairs enumerated in zcl.json and does not encompass all attributeAccessInterface pairings, it becomes essential to query both the ATTRIBUTE and PACKAGE_OPTION tables.